[PM-13374] Add UserId, CipherId, FolderId #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
previously approved these changes
May 26, 2025
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 75.88% 75.87% -0.01%
==========================================
Files 259 259
Lines 23726 23755 +29
==========================================
+ Hits 18004 18025 +21
- Misses 5722 5730 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dani-garcia
previously approved these changes
May 26, 2025
This was referenced May 27, 2025
Hinton
changed the title
gbubemismith
previously approved these changes
Jun 2, 2025
…re-uuids # Conflicts: # crates/bitwarden-core/src/client/encryption_settings.rs # crates/bitwarden-core/src/client/internal.rs
dani-garcia
previously approved these changes
Jun 3, 2025
…re-uuids # Conflicts: # crates/bitwarden-core/src/client/internal.rs # crates/bitwarden-core/src/mobile/crypto.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-vault/src/collection.rs # crates/bitwarden-vault/src/folder.rs
gbubemismith
previously approved these changes
Jun 10, 2025
dani-garcia
previously approved these changes
Jun 11, 2025
…re-uuids # Conflicts: # crates/bitwarden-core/src/auth/auth_request.rs # crates/bitwarden-core/src/client/test_accounts.rs # crates/bitwarden-core/src/key_management/mod.rs # crates/bitwarden-core/tests/register.rs
…re-uuids # Conflicts: # crates/bitwarden-core/src/key_management/crypto.rs
|
dani-garcia
previously approved these changes
Jun 19, 2025
…re-uuids # Conflicts: # Cargo.lock # bitwarden_license/bitwarden-sm/src/projects/create.rs # bitwarden_license/bitwarden-sm/src/projects/update.rs # bitwarden_license/bitwarden-sm/src/secrets/create.rs # bitwarden_license/bitwarden-sm/src/secrets/update.rs # crates/bitwarden-core/src/auth/auth_request.rs # crates/bitwarden-core/src/client/internal.rs # crates/bitwarden-core/src/key_management/crypto.rs # crates/bitwarden-core/src/key_management/mod.rs # crates/bitwarden-uniffi/src/vault/ciphers.rs # crates/bitwarden-vault/Cargo.toml # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-vault/src/cipher/mod.rs # crates/bitwarden-vault/src/collection.rs # crates/bitwarden-vault/src/folder/folder_models.rs # crates/bitwarden-vault/src/lib.rs
|
dani-garcia
approved these changes
Aug 21, 2025
This was referenced Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13374
📔 Objective
Continues the work on #225 by introducing
UserId,CipherIdandFolderId. It also propagates theOrganizationIddeeper into the core crate.uuidmacro touuid_newtype, avoids collision with the macro fromuuidcrate.Hashto the uuids.new_v4primarily useful in tests to generate valid UUID v4 based IDs.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes